Add repo-managed git hooks for local validation#555
Merged
Conversation
danbar2
previously approved these changes
Apr 27, 2026
gflarity
reviewed
Apr 28, 2026
gflarity
left a comment
Contributor
There was a problem hiding this comment.
Just a few minor things.
gflarity
previously approved these changes
May 4, 2026
renormalize
previously approved these changes
May 5, 2026
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
eef60e9
renormalize
approved these changes
May 6, 2026
danbar2
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds tracked Git hooks for local validation and Make targets to manage them locally.
.githooks/pre-committo runmake validate.githooks/pre-pushto runmake testmake install-hooksto setcore.hooksPathto.githooksmake uninstall-hooksto remove the local hook configurationmake validate, while keepingmake checkasvalidateplus the clean-tree assertionThis keeps the hook logic versioned in the repository and aligned with the existing Make-based validation flow.
Which issue(s) this PR fixes:
Fixes #554
Special notes for your reviewer:
The hooks are intentionally opt-in per clone.
make validateruns the same validation steps asmake checkwithout the final dirty-tree assertion, so generated or formatted changes can still be staged as part of a normal local workflow.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: