refactor(mnnvl): add group-aware ComputeDomain naming and lifecycle m…#551
Merged
shmuel-runai merged 3 commits intoApr 27, 2026
Merged
Conversation
533a7ac to
4d13059
Compare
…anagement Decouple CD name resolution from lifecycle functions so Sync and Delete work with named MNNVL groups (grove.io/mnnvl-group) in addition to the default auto-mnnvl path. Key changes: - Introduce cdNameInfo and getRequiredCDNames to collect distinct groups from all annotation layers (PCS, PCSG configs, clique templates) - Replace replica-index-parsing deletion with triageCDs (set diff via lo) - Add LabelMNNVLGroup to ComputeDomain resources for group filtering - Extend GenerateRCTName and generateComputeDomainName with optional group - Simplify Delete to reuse triggerDeletionOfComputeDomainsByName Made-with: Cursor
4d13059 to
2a232ac
Compare
shayasoolin
reviewed
Apr 27, 2026
shayasoolin
approved these changes
Apr 27, 2026
danbar2
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…anagement
What type of PR is this?
/kind feature
What this PR does / why we need it:
Decouple CD name resolution from lifecycle functions so Sync and Delete work with named MNNVL groups (grove.io/mnnvl-group) in addition to the default auto-mnnvl path.
Key changes:
Which issue(s) this PR fixes:
Ref #417