Add mnnvl-group annotation validation and extend webhook to PodClique…#535
Merged
shmuel-runai merged 3 commits intoApr 16, 2026
Merged
Conversation
fcb46b3 to
1046c11
Compare
shayasoolin
reviewed
Apr 16, 2026
danbar2
reviewed
Apr 16, 2026
danbar2
reviewed
Apr 16, 2026
…TemplateSpec level Introduce grove.io/mnnvl-group annotation support with DNS-1123 label validation, conflict detection (auto-mnnvl: disabled + mnnvl-group), and immutability enforcement. Extend MNNVL webhook validation from PCS metadata to the full spec hierarchy (PCS → template → clique).
1046c11 to
8a6083a
Compare
danbar2
approved these changes
Apr 16, 2026
shayasoolin
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…TemplateSpec level
/kind feature
What this PR does / why we need it:
Introduce grove.io/mnnvl-group annotation support with DNS-1123 label validation, conflict detection (auto-mnnvl: disabled + mnnvl-group), and immutability enforcement.
Extend MNNVL webhook validation from PCS metadata to the full spec hierarchy (PCS → template → clique).
Which issue(s) this PR fixes:
Refs #417