add cache options for pods managed by grove only#533
Merged
oleg-kushniriov merged 5 commits intoApr 16, 2026
Merged
Conversation
enoodle
previously approved these changes
Apr 15, 2026
danbar2
reviewed
Apr 15, 2026
renormalize
reviewed
Apr 15, 2026
danbar2
previously approved these changes
Apr 15, 2026
c76a837 to
e8d22a8
Compare
enoodle
previously approved these changes
Apr 15, 2026
danbar2
previously approved these changes
Apr 16, 2026
e8d22a8 to
1b141b1
Compare
shayasoolin
reviewed
Apr 16, 2026
…d pod not being cached
…caler to client cache
1b141b1 to
45be5be
Compare
shayasoolin
approved these changes
Apr 16, 2026
enoodle
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a label selector to the Pod informer cache so only pods with
app.kubernetes.io/managed-by: grove-operatorare listed/watched. On large clusters with tens of thousands of pods, the operator was caching every pod cluster-wide even though only a tiny fraction are grove-managed.This caused excessive memory usage and OOMKill risk.
The fix adds a
cache.ByObjectconfiguration forcorev1.PodincreateManagerOptions()that pushes filtering to the API server. Grove CRDs are not filtered because all instances are grove-managed by definition.Which issue(s) this PR fixes:
Fixes #530
Special notes for your reviewer:
isManagedPod()) were already filtering which cached events trigger reconciliation, but the underlying informer still stored all pods. This change moves filtering server-side.TestCreateManagernow usesenvtest.Environmentinstead of a fake REST host becausecache.ByObjecttriggers API discovery during manager creation. It skips gracefully when kubebuilder binaries are unavailable, consistent withTestRegisterControllers.Does this PR introduce a API change?
release-note
Additional documentation e.g., enhancement proposals, usage docs, etc.: