Refactor/e2e unify k8s clients#529
Merged
oleg-kushniriov merged 10 commits intoApr 20, 2026
Merged
Conversation
72dabb7 to
f75c8d1
Compare
danbar2
reviewed
Apr 20, 2026
danbar2
previously approved these changes
Apr 20, 2026
shayasoolin
reviewed
Apr 20, 2026
shayasoolin
approved these changes
Apr 20, 2026
danbar2
approved these changes
Apr 20, 2026
…another external client for other usage
0bf7ac4 to
0f8f36a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Replaces the 6-field Clients struct (Clientset, DynamicClient, GroveClient, CRClient, RestMapper, RestConfig) with a unified K8s struct that embeds controller-runtime client.Client. This eliminates the "which client do I use?" question from e2e test code — every Kubernetes operation goes through a single client with all types registered in one scheme.
Key changes:
Also includes:
Which issue(s) this PR fixes:
Fixes #519
Special notes for reviewer:
Does this PR introduce a API change?
NONE
Additional documentation e.g., enhancement proposals, usage docs, etc.:
The e2e test framework now uses a single
K8sstruct for all Kubernetes operations: