feat: Expose pod index as a label to allow user-defined env vars to reference it via Downward API#505
Merged
julienmancuso merged 1 commit intoApr 1, 2026
Conversation
danbar2
approved these changes
Apr 1, 2026
gflarity
approved these changes
Apr 1, 2026
…eference it via Downward API Signed-off-by: Julien Mancuso <jmancuso@nvidia.com>
bb81d87 to
f73b6b1
Compare
Contributor
|
/ok to test |
@gflarity, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
|
/ok to test f73b6b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
As a PCS user, I want to define custom environment variables (e.g.
ENGINE_IDfor Dynamo) that are derived fromGROVE_PCLQ_POD_INDEX. This is not possible today because the operator injectsGROVE_PCLQ_POD_INDEXas a direct value at pod creation time -- there is no label or field users can reference via the Kubernetes Downward API in their own env var definitions.This PR:
grove.io/podclique-pod-indexcarrying the pod's index within its PodClique.GROVE_PCLQ_POD_INDEXfrom a direct-value env var to one sourced viafieldReffrom that label.This follows the same pattern already used for
GROVE_PCSG_INDEX/GROVE_PCSG_NAME.Users can now define their own env vars referencing the pod index:
Which issue(s) this PR fixes:
Fixes #506
Special notes for your reviewer:
This is a backward-compatible change.
GROVE_PCLQ_POD_INDEXstill resolves to the same value at runtime -- the only difference is that it is now sourced from a pod label viafieldRefinstead of being set as a direct value.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: