Ritika/headlessservice#50
Merged
unmarshall merged 2 commits intoApr 10, 2025
Merged
Conversation
Collaborator
|
Please rebase this PR. Then i can look at it as that will also allow me to test it. |
bb96fc2 to
61a8128
Compare
Contributor
Author
Rebased and updated |
dmitsh
reviewed
Apr 1, 2025
unmarshall
requested changes
Apr 4, 2025
46513aa to
58efe8a
Compare
Remove bool CreateHeadlessService variable If Service Spec is specified, headless service will be created Refactor the Pod Clique and Pod naming convention PC name : <PGS.Name>-<PGS.ReplicaID>-<PC.Name> Pod name : <PC.Name>-<PC.ReplicaID> Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
cd9c8da to
3cb391f
Compare
unmarshall
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.