Crd upgrader impl#497
Merged
Merged
Conversation
f125cf7 to
0646071
Compare
shayasoolin
reviewed
Mar 30, 2026
Ronkahn21
requested changes
Mar 30, 2026
shayasoolin
previously approved these changes
Mar 31, 2026
Ronkahn21
reviewed
Mar 31, 2026
Ronkahn21
previously approved these changes
Mar 31, 2026
shayasoolin
previously approved these changes
Mar 31, 2026
- Fix goimports-reviser ordering in installer.go and installer_test.go (project imports before general/third-party) - Add E2E tests for crd_installer (AllCRDsExist, InitContainerCompleted, Idempotent) - Add crd_installer to CI e2e and e2e-skip matrices Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The init container used command: ["/manager", "install-crds"] but ko-built images don't place the binary at /manager. Switch to args: ["install-crds"] to use the ko image's entrypoint, matching how the main container is invoked. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0061534 to
0106fb6
Compare
Ronkahn21
approved these changes
Mar 31, 2026
shayasoolin
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Solves #436
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: