Add GREP-417: Selective MNNVL proposal#492
Merged
shmuel-runai merged 6 commits intoApr 16, 2026
Merged
Conversation
Introduce annotation-based ComputeDomain injection at the PodClique level, enabling per-clique MNNVL control without requiring cluster-wide auto-MNNVL enablement.
shayasoolin
reviewed
Mar 18, 2026
Rewrite the GREP-417 proposal as a unified feature doc covering the full desired state of auto-MNNVL. Key design changes: - Opt-in model via grove.io/mnnvl-group annotation (replaces opt-out) - Single annotation with numeric group values or "none" for opt-out - Multi-layer propagation (PCS → PCSG → PCLQ) with override support - New mnnvl.mode config field (auto/enabled/disabled), clean break from the old autoMNNVLEnabled boolean - Comprehensive behavior matrix and decision flowchart - Background appendix on MNNVL, IMEX channels, and ComputeDomains
9075d86 to
a217d55
Compare
shayasoolin
reviewed
Mar 31, 2026
danbar2
reviewed
Mar 31, 2026
danbar2
reviewed
Mar 31, 2026
danbar2
reviewed
Mar 31, 2026
danbar2
reviewed
Mar 31, 2026
0d2de0e to
1431a6e
Compare
258f19c to
4024951
Compare
gflarity
reviewed
Apr 16, 2026
shayasoolin
previously approved these changes
Apr 16, 2026
danbar2
previously approved these changes
Apr 16, 2026
danbar2
approved these changes
Apr 16, 2026
shayasoolin
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Introduce annotation-based ComputeDomain injection at the PodClique level, enabling per-clique MNNVL control without requiring cluster-wide auto-MNNVL enablement.
Which issue(s) this PR fixes:
Ref #417