Skip to content

Add GREP-417: Selective MNNVL proposal#492

Merged
shmuel-runai merged 6 commits into
ai-dynamo:mainfrom
shmuel-runai:grove-417/main-draft-grep
Apr 16, 2026
Merged

Add GREP-417: Selective MNNVL proposal#492
shmuel-runai merged 6 commits into
ai-dynamo:mainfrom
shmuel-runai:grove-417/main-draft-grep

Conversation

@shmuel-runai

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Introduce annotation-based ComputeDomain injection at the PodClique level, enabling per-clique MNNVL control without requiring cluster-wide auto-MNNVL enablement.

Which issue(s) this PR fixes:

Ref #417

Introduce annotation-based ComputeDomain injection at the PodClique
level, enabling per-clique MNNVL control without requiring cluster-wide
auto-MNNVL enablement.
@shmuel-runai shmuel-runai self-assigned this Mar 17, 2026
@copy-pr-bot

copy-pr-bot Bot commented Mar 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread docs/proposals/417-selective-mnnvl/README.md Outdated
Comment thread docs/proposals/417-selective-mnnvl/README.md Outdated
Comment thread docs/proposals/417-selective-mnnvl/README.md Outdated
Rewrite the GREP-417 proposal as a unified feature doc covering the
full desired state of auto-MNNVL. Key design changes:

- Opt-in model via grove.io/mnnvl-group annotation (replaces opt-out)
- Single annotation with numeric group values or "none" for opt-out
- Multi-layer propagation (PCS → PCSG → PCLQ) with override support
- New mnnvl.mode config field (auto/enabled/disabled), clean break
  from the old autoMNNVLEnabled boolean
- Comprehensive behavior matrix and decision flowchart
- Background appendix on MNNVL, IMEX channels, and ComputeDomains
@shmuel-runai shmuel-runai force-pushed the grove-417/main-draft-grep branch from 9075d86 to a217d55 Compare March 30, 2026 19:27
@shmuel-runai shmuel-runai marked this pull request as ready for review March 30, 2026 19:30
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
@shmuel-runai shmuel-runai force-pushed the grove-417/main-draft-grep branch from 0d2de0e to 1431a6e Compare April 13, 2026 10:33
@shmuel-runai shmuel-runai force-pushed the grove-417/main-draft-grep branch from 258f19c to 4024951 Compare April 15, 2026 16:54
Comment thread docs/proposals/417-auto-mnnvl/README.md Outdated
Comment thread docs/proposals/417-auto-mnnvl/README.md
shayasoolin
shayasoolin previously approved these changes Apr 16, 2026
danbar2
danbar2 previously approved these changes Apr 16, 2026
@shmuel-runai shmuel-runai dismissed stale reviews from danbar2 and shayasoolin via 5343479 April 16, 2026 10:49
@shmuel-runai shmuel-runai merged commit 29ff099 into ai-dynamo:main Apr 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants