add finalizer when build resource to reduce one patch call to api server#477
Merged
Conversation
Contributor
Author
|
We can add a test to add data |
Contributor
|
@kangclzjc i personally don't think a test is necessary for this change. If the other reviewers think it's necessary then we can try and add a test. |
Ronkahn21
reviewed
Mar 15, 2026
Ronkahn21
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall but I would want you to add tests for building the objects to make sure we build with finalizer on
Contributor
Author
Hi @Ronkahn21 , this PR use the same method which utils provide, I think already have the unit test for
|
danbar2
approved these changes
Apr 28, 2026
shayasoolin
approved these changes
Apr 28, 2026
d168500 to
f56a7bd
Compare
Signed-off-by: kangclzjc <kangz@nvidia.com>
f56a7bd to
a1c5865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/feature
What this PR does / why we need it:
Add finalizer for pcsg/pclq in advance to reduce one patch and reduce one call to api server. When we have hundreds of thousands of pcsg/pclq, it could reduce much pressure on api server.
Which issue(s) this PR fixes:
Fixes #450
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: