bug fix: prevent auto-mnnvl annotation injection on update#420
Merged
shmuel-runai merged 1 commit intoFeb 15, 2026
Merged
Conversation
…on updates The defaulting webhook called MutateAutoMNNVL unconditionally for both CREATE and UPDATE operations. For legacy PCS resources created before the MNNVL feature, this caused a deadlock: the defaulting webhook added the annotation on update, and the validating webhook rejected it as a forbidden post-creation addition — making the resource unmodifiable (e.g., finalizer removal was blocked during deletion). Gate MutateAutoMNNVL to only run on CREATE operations and add unit tests covering UPDATE operations and the full webhook pipeline for the legacy PCS migration scenario.
shayasoolin
reviewed
Feb 10, 2026
shayasoolin
left a comment
Contributor
There was a problem hiding this comment.
I might be missing something here, but after this change - what prevents the deletion/addition of the annotation, from new pcs yamls? Not legacy ones, I'm talking about the basic prevention of add/remove of this annotation post creation.
shayasoolin
approved these changes
Feb 11, 2026
gflarity
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The defaulting webhook called MutateAutoMNNVL unconditionally for both CREATE and UPDATE operations. For legacy PCS resources created before the MNNVL feature, this caused a deadlock: the defaulting webhook added the annotation on update, and the validating webhook rejected it as a forbidden post-creation addition — making the resource unmodifiable (e.g., finalizer removal was blocked during deletion).
Gate MutateAutoMNNVL to only run on CREATE operations and add unit tests covering UPDATE operations and the full webhook pipeline for the legacy PCS migration scenario.
Tested
Which issue(s) this PR fixes:
Fixes #416
Special notes for your reviewer: