Skip to content

Upgrade golang version and k8s deps patch version#412

Merged
unmarshall merged 6 commits into
ai-dynamo:mainfrom
unmarshall:version-uprades
Feb 9, 2026
Merged

Upgrade golang version and k8s deps patch version#412
unmarshall merged 6 commits into
ai-dynamo:mainfrom
unmarshall:version-uprades

Conversation

@unmarshall

Copy link
Copy Markdown
Collaborator

Upgraded k8s deps to version v0.34.3 (latest patch version for v0.34)

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • Upgrading to golang 1.25 allows usage of new language features.
  • Upgrading to the latest patch version v0.34 of k8s deps (api, apimachinery, client-go etc.)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a API change?

Upgrade to golang version 1.25
Upgrade k8s.io/* to v0.34.3

Additional documentation e.g., enhancement proposals, usage docs, etc.:


Upgraded k8s deps to version v0.34.3 (latest patch version for v0.34)

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@copy-pr-bot

copy-pr-bot Bot commented Feb 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
renormalize
renormalize previously approved these changes Feb 9, 2026

@renormalize renormalize left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indirect dependencies like apiextensions-apiserver are not synchronized across the modules. Can we sync that too?

go work sync

should do the trick.

Comment thread operator/go.mod
Comment thread scheduler/client/go.mod Outdated
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
renormalize
renormalize previously approved these changes Feb 9, 2026
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>

@renormalize renormalize left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduler/client does not seem to be synced. Can you check that once?

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@unmarshall

Copy link
Copy Markdown
Collaborator Author

scheduler/client does not seem to be synced. Can you check that once?

Done

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@unmarshall unmarshall merged commit 45e121b into ai-dynamo:main Feb 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants