Fix e2e diagnostic log artifact upload path#392
Merged
Conversation
Ronkahn21
reviewed
Feb 3, 2026
Ronkahn21
reviewed
Feb 3, 2026
Co-authored-by: Ron Kahn <122778260+Ronkahn21@users.noreply.github.com> Signed-off-by: Geoff Flarity <geoff.flarity@gmail.com>
ecd3cb5 to
dea82df
Compare
shayasoolin
previously approved these changes
Feb 4, 2026
Ronkahn21
reviewed
Feb 5, 2026
Ronkahn21
approved these changes
Feb 5, 2026
shayasoolin
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the e2e test diagnostic log artifact upload so logs are actually captured when tests fail.
The upload step was looking for files at
/tmp/e2e-*.log, butdebug_utils.gowrites diagnostic files to theoperator/directory with the patterne2e-diag-*.log. This mismatch meant no artifacts were ever uploaded despite the step succeeding (due toif-no-files-found: ignore).Changes:
/tmp/e2e-*.logtooperator/e2e-diag-*.logif-no-files-foundfromignoretowarn(since this step only runs on failure, missing files indicates a problem)Which issue(s) this PR fixes:
NONE - discovered while investigating test failures in https://github.com/ai-dynamo/grove/actions/runs/21635838738
Special notes for your reviewer:
The diagnostic files are written by
CollectAllDiagnostics()inoperator/e2e/tests/debug_utils.gowhich creates files likee2e-diag-Test_TAS16_MultiReplicaPCSWithThreeLevelHierarchy_2026-02-03_15-46-29.login the current working directory (which isoperator/when runningmake test-e2e).Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: