Auto-MNNVL: validate annotation values and sync design doc#386
Merged
shmuel-runai merged 3 commits intoFeb 4, 2026
Conversation
Update design document to match implementation details. Add strict validation for grove.io/auto-mnnvl annotation values Changes: - Update design doc with correct config paths and annotation values - Reject invalid annotation values (must be "enabled" or "disabled")
shayasoolin
reviewed
Feb 2, 2026
shayasoolin
previously approved these changes
Feb 2, 2026
Ronkahn21
reviewed
Feb 2, 2026
Signed-off-by: shmuel-runai <149931913+shmuel-runai@users.noreply.github.com>
Ronkahn21
approved these changes
Feb 4, 2026
shayasoolin
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: GREP-270
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Update the design document to match the implementation details. Add strict validation for grove.io/auto-mnnvl annotation values
Changes: