Auto-MNNVL: add PodSpec injection for MNNVL resourceClaims#385
Merged
shmuel-runai merged 2 commits intoFeb 2, 2026
Merged
Conversation
Implement InjectAutoMNNVLIntoPodSpec to inject MNNVL resourceClaims into PodSpecs for GPU workloads. The function: - Adds a pod-level PodResourceClaim referencing the RCT - Adds claim references to each container that requests GPU - Is idempotent (safe to call multiple times) - Logs injection actions at debug level Integration with PCS + PCSG controller: - Inject MNNVL claims when PCS controller creates PodClique resources - Propagate grove.io/auto-mnnvl annotation from PCS to PCSG - Inject MNNVL claims into PodCliques created via PCSG path Refactor test organization: - Move helper function tests to helpers_test.go
danbar2
previously approved these changes
Feb 2, 2026
shayasoolin
reviewed
Feb 2, 2026
danbar2
approved these changes
Feb 2, 2026
shayasoolin
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
ref: GREP-270
What this PR does / why we need it:
Implement InjectAutoMNNVLIntoPodSpec to inject MNNVL resourceClaims into PodSpecs for GPU workloads. The function:
Integration with PCS + PCSG controller:
Refactor test organization: