Skip to content

run e2e only if code changed and build pass#381

Merged
danbar2 merged 4 commits into
ai-dynamo:mainfrom
danbar2:run-e2e-conditions
Feb 2, 2026
Merged

run e2e only if code changed and build pass#381
danbar2 merged 4 commits into
ai-dynamo:mainfrom
danbar2:run-e2e-conditions

Conversation

@danbar2

@danbar2 danbar2 commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR optimizes E2E test execution by:

  1. Consolidating the E2E workflow into the "Build, Check and Test" workflow
  2. E2E tests now only run when there are changes to operator/** or .github/** paths
  3. E2E tests are gated behind successful completion of test, build, and check jobs

This reduces unnecessary CI resource consumption by skipping expensive E2E tests when:

  • Changes don't affect operator or workflow code
  • Build/test/check jobs have already failed

Which issue(s) this PR fixes:

Fixes #377

Special notes for your reviewer:

  • Deleted .github/workflows/e2e-test.yaml and merged its contents into build-check-test.yaml
  • Uses dorny/paths-filter@v3 action to detect path changes
  • E2E jobs have needs: [test, build, check, changes] to enforce ordering

Does this PR introduce a API change?

Comment thread .github/workflows/build-check-test.yaml
@danbar2 danbar2 force-pushed the run-e2e-conditions branch from a86aaa1 to 28754e7 Compare February 1, 2026 06:40
Comment thread .github/workflows/build-check-test.yaml
shayasoolin
shayasoolin previously approved these changes Feb 1, 2026
@danbar2 danbar2 force-pushed the run-e2e-conditions branch from 28754e7 to 2ae6d4a Compare February 1, 2026 13:46

@Ronkahn21 Ronkahn21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, removing this duplication from the makefile

Comment thread .github/workflows/build-check-test.yaml Outdated
@danbar2 danbar2 merged commit 3e3c600 into ai-dynamo:main Feb 2, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent triggering of e2e tests unless "Build, test, check" jobs succeed

4 participants