Fix tas label#380
Merged
Merged
Conversation
Ronkahn21
requested changes
Jan 29, 2026
Ronkahn21
left a comment
Contributor
There was a problem hiding this comment.
Good catch finding the edge case bug, I added a few comments
Contributor
Author
|
@Ronkahn21 , @unmarshall PTAL |
5e13b82 to
40fba24
Compare
unmarshall
requested changes
Jan 30, 2026
f245dbe to
70ecd84
Compare
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
Signed-off-by: kangclzjc <kangz@nvidia.com>
* Using named return types for WaitAndGetReadyNode Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
0292e38 to
f91087f
Compare
unmarshall
approved these changes
Feb 1, 2026
Ronkahn21
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix TAS randomly failure
Which issue(s) this PR fixes:
Fixes #379
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: