Skip to content

Introduces miscellaneous changes #38

Merged
unmarshall merged 1 commit into
ai-dynamo:mainfrom
unmarshall:reconciler
Mar 6, 2025
Merged

Introduces miscellaneous changes #38
unmarshall merged 1 commit into
ai-dynamo:mainfrom
unmarshall:reconciler

Conversation

@unmarshall

Copy link
Copy Markdown
Collaborator

This PR introduces the following changes:

  • Introduces GroveError custom error type. This should be used throughout.
  • Adds LastErrors to PodGangSet.Status - this will be used to monitor errors during the last reconciliation of the CR.
  • Adds AuthorizerConfig to controller configuration types. An authorizer webhook will be introduced in a subsequent PR. Relevant changes to helm chart has also been made. It is currently disabled.
  • Added reconciler registration code.
  • Fixed the issue with reconciler ServiceAccount not having cluster role to delete/create/update PodCliques.
  • Updated skaffold and remove the need to pull from GCR.
  • Added a convenience script and a make target to deploy add-ons - like metrics server and kwok which will be used for testing later on.

…de for reconcilers, refactored webhooks pkg

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@unmarshall unmarshall merged commit 210e39f into ai-dynamo:main Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants