Split e2e cluster creation#371
Merged
Merged
Conversation
a64386a to
966c360
Compare
shayasoolin
reviewed
Feb 2, 2026
a6f37e3 to
21e2734
Compare
shayasoolin
previously approved these changes
Feb 3, 2026
d76da1f to
7c4a6b4
Compare
gflarity
reviewed
Feb 3, 2026
603a8bf to
ac0110f
Compare
gflarity
reviewed
Feb 4, 2026
gflarity
left a comment
Contributor
There was a problem hiding this comment.
Review of the Python cluster creation script. Nice work overall - a few suggestions below!
gflarity
reviewed
Feb 4, 2026
gflarity
left a comment
Contributor
There was a problem hiding this comment.
Thanks for switching to python. I found a couple issues but otherwise it's looking good.
shayasoolin
previously approved these changes
Feb 5, 2026
gflarity
reviewed
Feb 6, 2026
gflarity
previously approved these changes
Feb 6, 2026
…actual booleans Typer passes environment variables as strings, so 'False' was being treated as truthy. Now properly convert string booleans to bool type.
Commit 34d129e added topology tests that use busybox images, but commit 122d0bc deleted operator/e2e/dependencies.yaml which contained the busybox reference. This caused topology tests to fail because busybox wasn't being pre-pulled into the local registry. The topology test YAMLs reference registry:5001/busybox:latest, which requires busybox to be in the local k3d registry. Pre-pulling is not optional - without it, test pods fail with ImagePullBackOff. Added busybox back to operator/hack/dependencies.yaml and updated create-e2e-cluster.py to pre-pull it into the local registry.
c8d07af to
330573e
Compare
shayasoolin
previously approved these changes
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
reviewed
Feb 9, 2026
shmuel-runai
approved these changes
Feb 9, 2026
shmuel-runai
left a comment
Contributor
There was a problem hiding this comment.
Great update, very needed
LGTM
shayasoolin
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: