Auto-MNNVL: Update PCS's webhook support auto-mnnvl#370
Merged
shmuel-runai merged 3 commits intoJan 28, 2026
Conversation
Mutating webhook (on create): - Automatically adds grove.io/auto-mnnvl: "true" annotation when MNNVL is globally enabled and PCS requests GPUs - Respects existing annotation values (allows opt-out with "false") Validating webhook (on create): - Rejects PCS with auto-mnnvl: "true" if MNNVL feature is disabled Validating webhook (on update): - Enforces annotation immutability after creation General: - Add flexible WithContainer/WithInitContainer builder methods - Add NewGPUContainer/NewContainer helper functions - Add WithAnnotations to PodCliqueSetBuilder - Remove deprecated test-envtest from the make test
shayasoolin
reviewed
Jan 27, 2026
shayasoolin
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Mutating webhook (on create):
Validating webhook (on create):
Validating webhook (on update):
General:
Which issue(s) this PR fixes:
GREP-270
Special notes for your reviewer:
Does this PR introduce a API change?
NONE