fix typo in SO1 and SO2 tests#365
Merged
Merged
Conversation
Ronkahn21
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a typo in
Test_SO1_InorderStartupOrderWithFullReplicasandTest_SO2_InorderStartupOrderWithMinReplicaswheredefaultPollTimeout(4 minutes) was mistakenly used instead ofdefaultPollInterval(5 seconds) for the polling interval.This caused the tests to sleep for 4 minutes between poll checks, even when pods were already ready. The tests would pass but take ~4 minutes longer than necessary.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
The fix changes
Interval: defaultPollTimeouttoInterval: defaultPollIntervalin two test cases. The other startup ordering tests (SO3, SO4) already use the correct value.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: