Danbar/e2e rolling update 10#356
Merged
Merged
Conversation
shayasoolin
reviewed
Jan 20, 2026
shayasoolin
previously approved these changes
Jan 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR enhances the rolling update functionality and fixes test infrastructure for e2e tests. The main focus is on fixing Test_RU10 to properly verify delete-first rolling update behavior when resources are insufficient, and improving Docker image handling in the test setup.
Changes:
- Fixed logic in
mutateUpdatedReplicato correctly track updated replicas when a rolling update completes - Updated Test_RU10 to verify delete-first strategy behavior with cordoned nodes
- Refactored Docker image pulling logic to avoid duplication and add authentication support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| operator/internal/controller/podclique/reconcilestatus.go | Added handling for the window between rolling update completion and hash update |
| operator/e2e/tests/rolling_updates_test.go | Uncommented and fixed Test_RU9 and Test_RU10, updated timeouts and verification logic |
| operator/e2e/setup/shared_cluster.go | Added Docker authentication support and extracted common image pull logic |
| operator/e2e/setup/k8s_clusters.go | Refactored to use common image pull helper function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ronkahn21
previously approved these changes
Jan 20, 2026
gflarity
reviewed
Jan 20, 2026
gflarity
reviewed
Jan 20, 2026
gflarity
reviewed
Jan 20, 2026
gflarity
reviewed
Jan 20, 2026
gflarity
reviewed
Jan 20, 2026
74055b8 to
53c1b55
Compare
gflarity
reviewed
Jan 21, 2026
gflarity
reviewed
Jan 21, 2026
gflarity
left a comment
Contributor
There was a problem hiding this comment.
Looking good, one question and one comment.
53c1b55 to
f44d01a
Compare
shayasoolin
approved these changes
Jan 22, 2026
Ronkahn21
approved these changes
Jan 22, 2026
f44d01a to
ad88be8
Compare
Collaborator
|
@unmarshall please review this fix for rolling updates |
gflarity
approved these changes
Jan 23, 2026
ad88be8 to
5d0c9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: