skip patch ObservedGeneration if no change#337
Merged
Conversation
86da468 to
ecd90e0
Compare
renormalize
approved these changes
Jan 16, 2026
renormalize
left a comment
Contributor
There was a problem hiding this comment.
I took the liberty to adapt changes to PCSG as well. thanks for the PR!
Signed-off-by: xulinfei <xulinfei@bytedance.com>
Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
0d64028 to
a65da3f
Compare
Collaborator
|
@xulinfei1996 Thanks for the PR. It would be great if you could follow some expectations that are required to raise a PR:
For now i have labeled this issue and added some description to the PR. |
unmarshall
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Optimizes number of
Patchcalls made to the kube-apiserver by explicitly inspecting if there is a change done toObservedGenerationw.r.tGeneration. If an update is required, only then make the patch call else skips making the call.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: