fix startup ordering checks to match implementation#323
Merged
Conversation
shayasoolin
previously approved these changes
Jan 15, 2026
renormalize
reviewed
Jan 15, 2026
Contributor
Author
|
@shayasoolin @renormalize Implemented feedback, reset the approval. PTAL again. |
8ce3157 to
9d259d3
Compare
9d259d3 to
8abf3a6
Compare
8abf3a6 to
415f4c5
Compare
415f4c5 to
66991e5
Compare
sanjaychatterjee
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, when considering startup order constraints, 02/S04 would expect all pods a podclique to start before a dependent podclique can start. However the implementation of start ordering (init container) actually only requires the MinAvailable number of pods to be started first. This PR updates the tests to confirm MinAvailable pods start first, matching the code.
Notes:
Which issue(s) this PR fixes:
Fixes #319
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: