Skip to content

Fixes for defaulting and validating webhooks#32

Merged
dmitsh merged 1 commit into
ai-dynamo:mainfrom
unmarshall:webhookfix
Feb 6, 2025
Merged

Fixes for defaulting and validating webhooks#32
dmitsh merged 1 commit into
ai-dynamo:mainfrom
unmarshall:webhookfix

Conversation

@unmarshall

@unmarshall unmarshall commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Following has been fixed in this PR:

  • Corrected the service port ensuring that webhook port is exposed
  • Corrected scope to now have '*' for both webhook configurations.
  • Corrected certs to have proper SANs
  • Made several corrections to defaulting webhook.
  • Introduced a new Makefile target clean-chart-resources that will clear all the copied and generated resources in charts.
  • In the API - PodGangSet ObjectMeta label is changed from inline to "json: metadata,omitempty".
  • Made corrections to skaffold.yaml - i am now able to run make deploy-local-debug and setup remote debugger.

@unmarshall
fixed webhook certs, ports, defaulting webhook, webhook config and API
dc90c94 
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@dmitsh dmitsh merged commit b9bcb09 into ai-dynamo:main Feb 6, 2025
@unmarshall unmarshall deleted the webhookfix branch March 9, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

1 more reviewer

@dmitsh dmitsh dmitsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unmarshall @dmitsh