Fix get selector labels for pod#318
Merged
gflarity merged 3 commits intoJan 15, 2026
Merged
Conversation
2586393 to
6ec5a2a
Compare
2f9d279 to
9f98c83
Compare
shayasoolin
approved these changes
Jan 15, 2026
Ronkahn21
approved these changes
Jan 15, 2026
Contributor
Author
|
I'm going to merge this with E2E failing as it passes locally and this PR will improve E2E stability generally anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
BUG
What this PR does / why we need it:
This PR fixes a bug in getSelectorLabelsForPods which was using k8sutils.GetFirstOwnerName, but this returns the PCSG name not the PCS name. The fix is just to get the PCS name as intended.
Which issue(s) this PR fixes:
Fixes #320
Does this PR introduce a API change?