Skip to content

Move header copyright from 2025 to 2026#300

Closed
kangclzjc wants to merge 1 commit into
ai-dynamo:mainfrom
kangclzjc:newyear
Closed

Move header copyright from 2025 to 2026#300
kangclzjc wants to merge 1 commit into
ai-dynamo:mainfrom
kangclzjc:newyear

Conversation

@kangclzjc

Copy link
Copy Markdown
Contributor

What type of PR is this?

CI/CD will check the header and compare the year.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a API change?


Additional documentation e.g., enhancement proposals, usage docs, etc.:


Signed-off-by: kangclzjc <kangz@nvidia.com>
@kangclzjc kangclzjc marked this pull request as ready for review January 4, 2026 01:55

@renormalize renormalize left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have to update the year in the license for the generated files every year. The rest of the ecosystem does not do this either.

There seems to be a gap in the add-license-headers target which is causing this diff in the generated files.

@gflarity

gflarity commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

I don't think we should have to update the year in the license for the generated files every year. The rest of the ecosystem does not do this either.

There seems to be a gap in the add-license-headers target which is causing this diff in the generated files.

Ya, we'd just add 2026 to new files.

@kangclzjc

Copy link
Copy Markdown
Contributor Author

No problem, I add this because I see that CI/CD can't pass the check

@renormalize

Copy link
Copy Markdown
Contributor

Turns out it was make generate that was causing the issue. I had misread the failure.

Generated files had YEAR in them, and the convention is to not add the YEAR in such files (see https://github.com/kubernetes/kubernetes). I've raised #307 to follow this convention so we don't see issues like this again. Thanks @kangclzjc for originally raising this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants