Skip to content

Api/add name to topology constraint group#299

Merged
Ronkahn21 merged 3 commits into
ai-dynamo:mainfrom
Ronkahn21:api/add-name-to-topology-constraint-group
Dec 31, 2025
Merged

Api/add name to topology constraint group#299
Ronkahn21 merged 3 commits into
ai-dynamo:mainfrom
Ronkahn21:api/add-name-to-topology-constraint-group

Conversation

@Ronkahn21

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind api
/kind feature

What this PR does / why we need it:

Adds a name field to TopologyConstraintGroupConfig in the scheduler API to make it easier to identify and manage topology constraint group configurations. The name is derived from the corresponding
PodCliqueScalingGroup (PCSG) name.

This change benefits:

  • Easier identification when editing or adding topology constraint group configs
  • Support for downstream schedulers (KAI) to reference and manage these configs by name

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The name field is marked as required in the CRD. It will be automatically populated from the corresponding PCSG name by the operator.

Does this PR introduce a API change?

action required: TopologyConstraintGroupConfig now requires a `name` field. This field is automatically populated from the corresponding PodCliqueScalingGroup name.

Additional documentation e.g., enhancement proposals, usage docs, etc.:

- Updated scheduler API documentation to include the new `name` field
- Updated topology design document with the field description

Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…raintGroup

Signed-off-by: Ron Kahn <rkahn@nvidia.com>

@sanjaychatterjee sanjaychatterjee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a temporary measure until we have scheduler backend to generate the KAI PodGroup.

@Ronkahn21 Ronkahn21 merged commit 4495c49 into ai-dynamo:main Dec 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants