Feat/create cluster topology and KAI topology#298
Merged
unmarshall merged 23 commits intoDec 30, 2025
Conversation
…-driven CR creation Move validation logic from admission webhook to struct-level kubebuilder markers and CEL rules. Operator now creates/updates ClusterTopology CR from configuration at startup, eliminating need for pre-created resources. - Add CEL validation for domain/key uniqueness to ClusterTopology CRD - Add Pattern validation for Kubernetes label key format - Add Levels field to OperatorConfiguration.ClusterTopologyConfiguration - Remove admission webhook validation code and registration - Implement ensureClusterTopology() to manage CR lifecycle at startup - Update configuration validation with domain/key uniqueness checks - Remove ClusterTopology webhook from cert management - Update tests to reflect webhook removal
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…tterns Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…le permissions Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…alidation Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…istency Signed-off-by: Ron Kahn <rkahn@nvidia.com>
5d29c83 to
9c3353b
Compare
… logic for topology management Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
disable the feature by default
* Removed duplicate definition of TopologyDomain and TopologyLevel across config and core API. * Simplified sorting and removed unnecessary functions. * Added sample values for levels in values.yaml * Improved validations for OperatorConfiguration.ClusterTopology * Added missing JSON tag for LeaderElection in OperatorConfiguration * Refactored operator/cmd * Removed unused install-helm-charts script * Removed Makefile target added for running a specific int test. * Renamed and refactored internal/topology to internal/clustertopology. * Refactored application version handling. Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Ronkahn21
commented
Dec 28, 2025
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
tag. Fixing that uncovered missing role and role binding. This commit adds the missing role and rolebinding allowing Grove operate on leases Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
…e test run, to be changed later Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
…o longer set Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
…binding in values.yaml Signed-off-by: Ron Kahn <rkahn@nvidia.com>
sanjaychatterjee
approved these changes
Dec 30, 2025
unmarshall
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api
What this PR does / why we need it:
This PR enables automatic ClusterTopology and KAI Topology resource creation from operator configuration at startup.
Key Changes:
clusterTopology.namefield withclusterTopology.levelsarray to directly define topology hierarchyinternal/topology) that creates/updates both ClusterTopology and KAI Topology CRs at operator startupkai.scheduler/topologiesresourceWhy we need this:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Key Review Points:
Does this PR introduce an API change?
Yes
action required: Operator configuration API changed for cluster topology. Replace
clusterTopology.namewithclusterTopology.levelsarray defining topology hierarchy. Operator now automatically creates andmanages ClusterTopology and KAI Topology resources from configuration.