Skip to content

add mnnvl requirements GREP file#296

Merged
danbar2 merged 4 commits into
ai-dynamo:mainfrom
danbar2:danbar/mnnvl-requirements
Jan 6, 2026
Merged

add mnnvl requirements GREP file#296
danbar2 merged 4 commits into
ai-dynamo:mainfrom
danbar2:danbar/mnnvl-requirements

Conversation

@danbar2

@danbar2 danbar2 commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a API change?

NONE

Additional documentation e.g., enhancement proposals, usage docs, etc.:

GREP-270: mnnvl requirements

shayasoolin
shayasoolin previously approved these changes Dec 24, 2025

@nvrohanv nvrohanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left minor comment on purpose of opt-out that should be addressed.

Comment thread docs/designs/mnnvl.md Outdated
nvrohanv
nvrohanv previously approved these changes Dec 30, 2025
gflarity
gflarity previously approved these changes Jan 2, 2026
@danbar2 danbar2 dismissed stale reviews from shayasoolin, nvrohanv, and gflarity via 2f53da3 January 4, 2026 06:29

@nvrohanv nvrohanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @sanjaychatterjee can you take a look

@sanjaychatterjee sanjaychatterjee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbar2 danbar2 merged commit 0a69905 into ai-dynamo:main Jan 6, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants