Skip to content

Configuration and deployment of webhooks#29

Merged
unmarshall merged 2 commits into
ai-dynamo:mainfrom
unmarshall:webhook
Jan 28, 2025
Merged

Configuration and deployment of webhooks#29
unmarshall merged 2 commits into
ai-dynamo:mainfrom
unmarshall:webhook

Conversation

@unmarshall

@unmarshall unmarshall commented Jan 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR introduces the following:

  1. Scripts are added in operator/hack which will help prepare helm templates before skaffold picks it up for local deployment.
  2. Script to generate required PKI resources - these will never be checked in git repo.
  3. Introduced webhook configuration helm template
  4. Introduced secret helm template for webhook server certificate
  5. Mounted webhook server certificate secret as a volume on to operator deployment
  6. Added support for deploying operator specific resources within any namespace via make target.

NOTE: Awaiting PGS samples. Once these are available then we can do some e2e tests for webhooks.

@unmarshall unmarshall marked this pull request as draft January 25, 2025 14:12
@unmarshall

unmarshall commented Jan 25, 2025

Copy link
Copy Markdown
Collaborator Author

NOTE: Do not approve this yet - need to add webhook configuration for defaulting webhook.

@unmarshall
Added scripts to generate tls, copy-crds, refactored scripts
c4a2ab4 
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@unmarshall
added defaulting webhook configuration, changed package from mutating…
e85031d 
… to defaulting

Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
@unmarshall unmarshall marked this pull request as ready for review January 27, 2025 04:26
@unmarshall

unmarshall commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator Author

Additional changes:

  • Added mutating webhook configuration for defaulting webhook.
  • Changed the package from mutating to defaulting.

@unmarshall unmarshall merged commit ced9034 into ai-dynamo:main Jan 28, 2025
@unmarshall unmarshall deleted the webhook branch March 9, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

1 more reviewer

@dmitsh dmitsh dmitsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unmarshall @dmitsh