feat: remove useless branch condition#289
Merged
Merged
Conversation
renormalize
approved these changes
Dec 11, 2025
renormalize
suggested changes
Dec 11, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Please run make check, and commit those changes in as well, since the pipeline currently fails. Thanks.
Contributor
Author
|
/fixed |
renormalize
previously approved these changes
Dec 11, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Will be merged with a second approval.
Contributor
|
Hmm, E2E tests are failing. Can you try rebasing on main? I put some fixes in to make the E2E more robust. Otherwise it might be something else. |
renormalize
suggested changes
Dec 18, 2025
Contributor
There was a problem hiding this comment.
Hi @ls-2018, could you revert the go.mod and go.sum changes? We'd like to keep dependency upgrades (be it direct or indirect) separate from code changes.
Thanks.
renormalize
approved these changes
Dec 18, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick changes @ls-2018!
gflarity
approved these changes
Dec 18, 2025
Collaborator
|
Can you please rebase and check if the E2E tests will pass? |
Signed-off-by: acejilam <acejilam@gmail.com>
sanjaychatterjee
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
remove useless branch condition
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: