Skip to content

E2e tests rolling updates#280

Merged
gflarity merged 12 commits into
ai-dynamo:mainfrom
gflarity:e2e_tests_rolling_updates
Jan 7, 2026
Merged

E2e tests rolling updates#280
gflarity merged 12 commits into
ai-dynamo:mainfrom
gflarity:e2e_tests_rolling_updates

Conversation

@gflarity

@gflarity gflarity commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

PR for Rolling Updates tests. I was able to get most of them working

  1. Please take a look at the fix in rollingupdate.go. Seems like a simple enough typo/cut and pass issue?
  2. These fails are failing still:
    • 10 (always fails) and
    • 18 fails intermittently

Comment thread operator/e2e/tests/setup.go Outdated
Comment thread operator/e2e/utils/k8s_client.go Outdated
Comment thread operator/e2e/tests/rolling_updates_test.go Outdated
Comment thread operator/e2e/tests/rolling_updates_test.go Outdated
Comment thread operator/e2e/tests/rolling_updates_test.go Outdated
Comment thread operator/e2e/tests/rolling_updates_test.go Outdated
@gflarity gflarity force-pushed the e2e_tests_rolling_updates branch from 9ca670b to 9fdd904 Compare December 3, 2025 21:14
@gflarity

gflarity commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @shayasoolin, please take a look:

  • removed the unused functions I missed
  • moved the helper functions into separate files
  • reduced repetition in the tests themselves

T

@gflarity gflarity requested a review from shayasoolin December 3, 2025 21:28
shayasoolin
shayasoolin previously approved these changes Dec 4, 2025
Comment thread operator/e2e/tests/debug_utils.go Outdated
Comment thread operator/e2e/tests/debug_utils.go Outdated
Comment thread operator/e2e/tests/rolling_update_tracker.go
Comment thread operator/e2e/tests/rolling_update_utils.go Outdated
Comment thread operator/e2e/tests/rolling_update_utils.go Outdated
@gflarity gflarity force-pushed the e2e_tests_rolling_updates branch from 36cd0ab to 30643e0 Compare December 17, 2025 19:12
shayasoolin
shayasoolin previously approved these changes Dec 18, 2025
Comment thread operator/e2e/tests/debug_utils.go Outdated
Comment thread operator/e2e/tests/debug_utils.go
@sanjaychatterjee

Copy link
Copy Markdown
Collaborator

@gflarity who is debugging the failures on 10 and 18? @unmarshall and @renormalize can you please take a look as well?

@shmuel-runai shmuel-runai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@gflarity gflarity merged commit 1db7d08 into ai-dynamo:main Jan 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants