Skip to content

implement validation for update operation#27

Merged
unmarshall merged 1 commit into
ai-dynamo:mainfrom
dmitsh:ds-validate-update
Feb 4, 2025
Merged

implement validation for update operation#27
unmarshall merged 1 commit into
ai-dynamo:mainfrom
dmitsh:ds-validate-update

Conversation

@dmitsh

@dmitsh dmitsh commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@dmitsh dmitsh self-assigned this Jan 22, 2025
@dmitsh dmitsh marked this pull request as draft January 22, 2025 18:40
@dmitsh dmitsh force-pushed the ds-validate-update branch 2 times, most recently from 136dba7 to 2e4bc64 Compare January 28, 2025 01:55
@dmitsh dmitsh marked this pull request as ready for review January 28, 2025 01:58
@dmitsh dmitsh force-pushed the ds-validate-update branch 2 times, most recently from 774d58a to 325e050 Compare January 29, 2025 04:14
Comment thread operator/internal/webhook/pgs/validation/podgangset.go Outdated
Comment thread operator/internal/webhook/pgs/validation/podgangset.go Outdated
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
@dmitsh dmitsh force-pushed the ds-validate-update branch from 325e050 to c20b25c Compare February 3, 2025 18:00
@dmitsh dmitsh requested a review from unmarshall February 3, 2025 18:00

@unmarshall unmarshall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@unmarshall unmarshall merged commit 3761230 into ai-dynamo:main Feb 4, 2025
@dmitsh dmitsh deleted the ds-validate-update branch February 4, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants