E2E tests for startup ordering#269
Merged
Merged
Conversation
shayasoolin
reviewed
Nov 23, 2025
The operator was using invalid image tags for the grove-initc init container because LD_FLAGS was empty, leaving git archive placeholders like $Format:%H$ in the version strings. Added buildLDFlagsForE2E() function to generate proper ldflags that override the placeholder values in internal/version/version.go with valid e2e test values. Also added debug logging to startup ordering tests to aid in troubleshooting.
53b53ef to
b90773e
Compare
shayasoolin
approved these changes
Nov 25, 2025
sanjaychatterjee
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
E2E Tests
What this PR does / why we need it:
This PR implements the startup ordering scenarios defined in the Grove Multi-Node QA Test Plan. It confirms that everything is working as expected as PR the test plan.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: