improve test coverage for internal/controller#252
Merged
gflarity merged 4 commits intoDec 9, 2025
Merged
Conversation
renormalize
previously approved these changes
Dec 9, 2025
4cdb46d to
c449e0a
Compare
sanjaychatterjee
previously approved these changes
Dec 9, 2025
d78f7c6
c449e0a to
d78f7c6
Compare
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
d78f7c6 to
7abbe25
Compare
sanjaychatterjee
approved these changes
Dec 9, 2025
shayasoolin
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing
What this PR does / why we need it:
Increased test coverage for internal/controller
Special notes for your reviewer:
Prompt:
Please create an idiomatic golang unit tests for this specific directory/package. Herea are the instructions:
Does this PR introduce a API change?