e2e tests gang scheduling#242
Merged
gflarity merged 15 commits intoNov 20, 2025
Merged
Conversation
b0f7495 to
6ca3861
Compare
shayasoolin
reviewed
Nov 4, 2025
shayasoolin
left a comment
Contributor
There was a problem hiding this comment.
I reviewed the infra code (shared_cluster.go and setup.go) changes, and the first new test in gang_scheduling_test.go.
I stopped there since my main comment is that I strongly suggest to invest time on having as many utility test functions as possible, and then reuse them for the test cases themselves.
We'll not just gain reusability and make it easier to maintain, but the test cases themselves will get much clearer as they will show as high-level function calls that look ideally as the comment above the test case: a list of steps.
Since this requires a non-trivial refactoring, I prefer to review the test logic itself after it's done. Thanks!
94db608 to
dfc20b3
Compare
Contributor
Author
|
Thanks @shayasoolin. I abstracted as much as I could into utility functions. PTAL. |
shayasoolin
previously approved these changes
Nov 5, 2025
f2cb7cc to
f57f415
Compare
Contributor
Author
|
@shayasoolin @sanjaychatterjee updated to incorporate last suggestions. PTAL. |
shayasoolin
previously approved these changes
Nov 6, 2025
ac591b6 to
52e7b92
Compare
julienmancuso
previously approved these changes
Nov 18, 2025
julienmancuso
left a comment
Contributor
There was a problem hiding this comment.
2 nits, otherwise lgtm. Great job
4c39c79
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
049b9a6 to
4cf27c8
Compare
julienmancuso
approved these changes
Nov 19, 2025
shayasoolin
approved these changes
Nov 19, 2025
sanjaychatterjee
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tests for gang scheduling as per the 'Grove Multi-Node QA Test Plan'.
What this PR does / why we need it:
Implements e2e tests for gang scheduling test scheduling.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: