add support for prepulling images to speed up tests on slow networks#241
Merged
Conversation
8272506 to
665c08b
Compare
shayasoolin
reviewed
Nov 4, 2025
shayasoolin
previously approved these changes
Nov 4, 2025
02ddd77 to
284e583
Compare
shayasoolin
previously approved these changes
Nov 5, 2025
986e724 to
e25cdd6
Compare
shayasoolin
previously approved these changes
Nov 6, 2025
fb17bde to
4057ec2
Compare
renormalize
reviewed
Nov 6, 2025
60f88b8 to
156a8b1
Compare
renormalize
previously approved these changes
Nov 7, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Posted a minor nit. But everything else looks good to me @gflarity! Thanks!
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Once @renormalize reviews, I can approve.
renormalize
approved these changes
Nov 7, 2025
Contributor
Author
|
@sanjaychatterjee Looks like we're good to merge. |
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Co-authored-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com> Signed-off-by: Geoff Flarity <geoff.flarity@gmail.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
afc8511 to
32524b7
Compare
sanjaychatterjee
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing Feature (Improvement)
What this PR does / why we need it:
Pulling images on slow networks can easily double the shared cluster setup time. However these images will not change very often and can be cached locally. This PR does this transparently. In particular this mades debugging failing tests faster when you don't have a 500mbps + internet connection.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: