added missed missed PR feedback#238
Merged
Merged
Conversation
9fd10e1 to
0ff0505
Compare
gflarity
commented
Nov 1, 2025
renormalize
suggested changes
Nov 3, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
thanks for the super quick follow-up PR @gflarity!
renormalize
suggested changes
Nov 3, 2025
Contributor
Author
|
Thanks @renormalize, updated. PTAL. |
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
0e1ffb0 to
beed13d
Compare
renormalize
approved these changes
Nov 4, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
thanks for all the changes @gflarity!
Contributor
|
Let's merge this first, and then #239. |
sanjaychatterjee
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What this PR does / why we need it:
This PR implements feedback made by @renormalize that was missed during the review process.
Here's the specific conversations:
#207 (comment)
#207 (comment)
#207 (comment)
#207 (comment)
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: