test coverage for internal/logger#229
Merged
gflarity merged 2 commits intoNov 5, 2025
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b651b4d to
1ff3d6a
Compare
Signed-off-by: Geoff Flarity <gflarity@nvidia.com>
1ff3d6a to
3cfd445
Compare
renormalize
approved these changes
Nov 5, 2025
sanjaychatterjee
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing
What this PR does / why we need it:
Increased unit test coverage.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Here's the instructions:
Please create an idiomatic golang unit tests for this specific directory/package. Herea are the instructions:
Does this PR introduce a API change?