Allow system:kube-controller-manager to update init container secret#221
Merged
Conversation
…d token in the satokensecret Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
renormalize
approved these changes
Oct 20, 2025
sanjaychatterjee
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
For init container, serviceaccount token needs to be mounted to check the startup order. Grove creates one secret per PodCliqueSet with type=kubernetes.io/service-account-token. KCM should inject a ca.crt and a token into the secret.Data but currently the service account
system:kube-controller-managerwhich KCM uses to do that is not exempted by the authorizer webhook. This causes the init container to fail to loop up the token in order to create a client which is then used to look up dependencies by making calls to KAPI.This PR adds
kubernetes.io/service-account-tokenas an exempted serviceaccount user.Which issue(s) this PR fixes:
Fixes #218
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: