Remove validation which prevents setting NodeSelector on PodSpec#203
Merged
Conversation
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
sanjaychatterjee
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Validating webhook was preventing setting a
NodeSelectoras part of aPodSpec. It was originally thought it would adversely influence network packing but that was an incorrect assumption. Network packing configuration (which will be enhanced in the upcoming PR) needs to always work in tandem withNodeSelectorconfiguration setting if explicitly set.Which issue(s) this PR fixes:
Fixes #198
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: