Remove LastOperation from CRDs and restructure component operators#192
Merged
Conversation
`PodCliqueScalingGroup` and `PodCliqueSet`. * Refactored structure of components to make it easy to correlate. * Combined constants into one file `internal/constants/constants.go` * Moved controller specific components within each controller package. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
renormalize
suggested changes
Sep 17, 2025
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
renormalize
reviewed
Sep 17, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
Can the imports be fixed?
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
renormalize
approved these changes
Sep 17, 2025
sanjaychatterjee
approved these changes
Sep 19, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind api
What this PR does / why we need it:
The motivation has been captured in the respective issues. This PR introduces the following changes:
LastOperationfrom Status ofPodClique,PodCliqueScalingGroupandPodCliqueSet.internal/constants/constants.goWhich issue(s) this PR fixes:
Fixes #190 #191
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: