Add Mutating Webhooks for PodGangSet#17
Merged
Merged
Conversation
Collaborator
|
@ritikasrivastava please rebase your PR then i can review it. |
a31010b to
35b7f1c
Compare
35b7f1c to
b2994e4
Compare
unmarshall
requested changes
Jan 16, 2025
Collaborator
|
Can you also add a short description to the PR? |
unmarshall
requested changes
Jan 18, 2025
c6cef52 to
536bcd4
Compare
unmarshall
requested changes
Jan 24, 2025
unmarshall
left a comment
Collaborator
There was a problem hiding this comment.
Can you rebase your PR on top of Dmitry's PR that got merged and also removes the UpdateStrategy?
There are some minor changes requested. Once that is done then we can merge this PR.
| } | ||
|
|
||
| func defaultPodCliqueTemplateSpec(cliqueSpecs []v1alpha1.PodCliqueTemplateSpec) { | ||
| for _, cliqueSpec := range cliqueSpecs { |
Collaborator
There was a problem hiding this comment.
For every PodClique, can replicas ever be 0? This is only possible if we need to support scale down to 0. Lets discuss this point in the next sync.
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
e63f4d2 to
abbfdf7
Compare
Signed-off-by: Ritika Srivastava <risrivastava@nvidia.com>
unmarshall
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaulting webhook to add defaults to PodGangSet CR is added in this PR.