API changes for Gang termination#107
Merged
Merged
Conversation
* `TerminationDelay` moved out of `SchedulingPolicyConfig` to now be directly under `PodGangSetTemplateSpec` * Defaulted `TerminationDelay` to 30s if not specified. * Added validation for `RoleName` and adapted validation for `TerminationDelay`. * Removed `TerminationDelay` from scheduler `PodGang` API type. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
2cdf4f7 to
b9be221
Compare
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
b9be221 to
622c65f
Compare
renormalize
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for
Gang termination. While going over the existing API it was realized that some changes are required before we can implement Gang termination.Following changes are introduced as part of this PR:
TerminationDelaymoved out ofSchedulingPolicyConfigto now be directly underPodGangSetTemplateSpec.TerminationDelayto 30s if not specified.TerminationDelayfrom schedulerPodGangAPI type.RoleNameand adapted validation forTerminationDelay.