Fix HPA selector labels for PodCliques created by PodCliqueScalingGroups.#104
Merged
Conversation
…Group`s. * `HPA` now identifies `Pod`s to scale on `grove.io/podcliquescalinggroup`, and `grove.io/podclique` labels for `PodClique`s created by `PodCliqueScalingGroup` and `PodGangSet` respectively. This is done instead of `app.kubernetes.io/name`, since the value of this label on `Pod`s is the `PodClique` name, and this can not be used for `PodClique`s created by `PodCliqueScalingGroup`s. * The `app.kubernetes.io/component` label's value is now either `pgs-podclique` if the `PodClique` is created by `PodGangSet`, or `pcsg-podclique` if the `PodClique` is created by `PodCliqueScalingGroup`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HPAnow identifiesPods to scale ongrove.io/podcliquescalinggroup, andgrove.io/podcliquelabels forPodCliques created byPodCliqueScalingGroupandPodGangSetrespectively. This is done instead ofapp.kubernetes.io/name, since the value of this label onPods is thePodCliquename, and this can not be used forPodCliques created byPodCliqueScalingGroups.The
app.kubernetes.io/componentlabel's value is now eitherpgs-podcliqueif thePodCliqueis created byPodGangSet, orpcsg-podcliqueif thePodCliqueis created byPodCliqueScalingGroup.