Refactor PodGangSet and PodGang APIs#101
Merged
Merged
Conversation
* Removed RollingUpdateConfiguration. * Renamed PodGangTemplateSpec to PodGangSetTemplateSpec * Moved PriorityClassName to PodGangSetTemplateSpec * Introduced NetworkPackGroupConfig and NetworkPackGroupConfigs in SchedulingPolicyConfig. * Moved MinReplicas to AutoScalingConfig. * Introduced MinAvailable in PodCliqueSpec. Scheduler API changes: * Removed NetworkPackStrategy and replaced it with NetworkPackGroupConfigs. * Regenerated deepcopy and CRDs. * Partially adapted code to API changes. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Removes validation for Rolling update strategy and configuration. * Introduces validation for PodCliqueSpec.minAvailable. * Enhances validation for AutoScalingConfig. * Introduces validation for NetworkPackGroupConfigs. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* HPA component now uses `scaleConfig.minReplicas`. * `podGang.Spec.PriorityClassName` is derived from `podGangSet.Spec.Template.PriorityClassName` now. * PodGroups now rely on `pclqTemplate.spec.minAvailable` now, instead of `minReplicas`. * Defaulting webhook modified to be coherent with the modified API. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Added constants for PodGang status phase. * Corrected nil pointer dereference in admission webhooks. * Regenerated code and CRDs. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
renormalize
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Operator API changes:
SchedulingPolicyConfig.
Scheduler API changes:
Namefield forPodGroup.SchedulingPhasetoPhaseand introduced constants for different Phases.