Introduce docs/getting-started.md.#100
Merged
Merged
Conversation
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* `MinReplicas` is defaulted to `Replicas` if not specified. This was not present in the expected output. * `StartupType` and `SchedulingPolicy` are both defaulted through through the `+kubebuilder:default` tags, instead of defaulting in the webhook. Therefore, such defaulting behavior can not be unit tested. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
unmarshall
requested changes
Jul 4, 2025
| kubectl apply -f ./samples/simple/simple1.yaml | ||
| ``` | ||
|
|
||
| - You can now fetch resources like `PodGangSet`, `PodGang`, `PodClique`, `PodCliqueScalingGroup`, etc. created by the Grove operator, by running: |
Collaborator
There was a problem hiding this comment.
specify short-names for each of these resources so that consumers know which short name is for which resource.
… make target. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
unmarshall
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a the
getting-started.mddocument.Fixes field name and values for start-up ordering in
operator/samples/simple/simple2-explicit-startup-order.yaml.Fixes currently failing unit tests.