Skip to content

Add validations for topology constraints on PCS #304

@unmarshall

Description

@unmarshall

What you would like to be added?

Enhance the existing validating webhook to include additional validations for TopologyConstraints that are defined on different levels in a PodCliqueSet.

  • PodCliqueSet.Spec.Template.TopologyConstraint should not use denser packing domain as compared to TopologyConstraints defined either at PCLQ or PCSG level.
  • PodCliqueSet.Spec.Template.PodCliqueScalingGroupConfigs[x].TopologyConstraint should not use denser packing domain as compared to any TopologyConstraints defined in the constituent PCLQs for the PCSG.
  • Once TopologyConstraints have been set for a PCS, they cannot be updated. KAI scheduler today does not listen to PodGang events (only listens to Pod events), therefore if something changes in a PodGang then KAI scheduler will not be able react to it and update its respective PodGroups. This is a short lived limitation and should be fixed when we introduce scheduler backends.
  • If TAS is disabled and then a new PCS workload with topology constraints set is deployed then it should be disallowed. This is again a short lived limitation which gets removed once we introduce scheduler backends.
  • Validates that all TopologyConstraint.PackDomain belong to one of the supported TopologyDomains as configured in TAS config.

Why is this needed?

To ensure that the topology constraints do not violate the topology domain hierarchy.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions