Rename Grove CR PodGangSet to PodCliqueSet #127
Closed
sanjaychatterjee
started this conversation in
General
Replies: 1 comment
-
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Grove v1alpha1 API currently defines a top-level custom resource named
PodGangSetthat groups togetherPodCliques that need to be gang-scheduled and managed together, where aPodCliqueis a group of Pods that share the same Pod template. APodGangSetCR can be horizontally scaled, and eachPodGangSetreplica owns and manages all thePodCliqueCRs that are instantiated exclusively for that replica.Now, inside a
PodGangSetreplica, Grove supports auto-scaling ofPodCliques, either independently or as part of a group when defined in aPodCliqueScalingGroupconfiguration. When scaling aPodCliqueindependently, Pods are added to (or removed from) an existingPodClique. On the other hand, when scaling aPodCliqueScalingGroup, eachPodCliqueScalingGroupreplica owns and manages thePodCliqueCRs that are instantiated exclusively for that replica.As a result, a
PodGangSetCR essentially manages the lifecycle of a set ofPodCliques--some independently and some as groups--within and across all of its replicas.Hence, I would like to propose to rename the
PodGangSetCR as aPodCliqueSet, which would be represent something that is closer to its actual functionality.I would love to hear your arguments for or against this proposal, as well as, other alternative names as well.
Beta Was this translation helpful? Give feedback.
All reactions